lkml.org 
[lkml]   [2011]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 2/6] TTY: msm_serial, remove unneeded console set
    Date
    It doesn't make sense to set console to uart_port in console->setup.
    At that time the console is set by uart_add_one_port already.

    The call chain looked like:
    uart_add_one_port()
    uport->cons = drv->cons; <= once
    uart_configure_port()
    register_console()
    console->setup()
    port->cons = co; <= second time

    Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    Cc: Greg Kroah-Hartman <gregkh@suse.de>
    Cc: Alan Cox <alan@linux.intel.com>
    ---
    drivers/tty/serial/msm_serial.c | 2 --
    1 files changed, 0 insertions(+), 2 deletions(-)

    diff --git a/drivers/tty/serial/msm_serial.c b/drivers/tty/serial/msm_serial.c
    index e6ba838..29cbfd8 100644
    --- a/drivers/tty/serial/msm_serial.c
    +++ b/drivers/tty/serial/msm_serial.c
    @@ -804,8 +804,6 @@ static int __init msm_console_setup(struct console *co, char *options)
    if (unlikely(!port->membase))
    return -ENXIO;

    - port->cons = co;
    -
    msm_init_clock(port);

    if (options)
    --
    1.7.6



    \
     
     \ /
      Last update: 2011-07-14 14:37    [W:0.018 / U:153.128 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site