Messages in this thread | | | Date | Wed, 13 Jul 2011 12:25:20 +0200 | From | Tejun Heo <> | Subject | Re: [PATCH 1/3] ptrace_init_task: initialize child->jobctl explicitly |
| |
On Fri, Jul 08, 2011 at 07:13:39PM +0200, Oleg Nesterov wrote: > new_child->jobctl is not initialized during the fork, it is copied > from parent->jobctl. Currently this is harmless, the forking task > is running and copy_process() can't succeed if signal_pending() is > true, so only JOBCTL_STOP_DEQUEUED can be copied. Still this is a > bit fragile, it would be more clean to set ->jobctl = 0 explicitly. > > Also, check ->ptrace != 0 instead of PT_PTRACED, move the > CONFIG_HAVE_HW_BREAKPOINT code up. > > Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
-- tejun
| |