lkml.org 
[lkml]   [2011]   [Jul]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] hfsplus: Add record offset check
From
On Wed, Jul 13, 2011 at 6:58 AM, Hin-Tak Leung <hintak_leung@yahoo.co.uk> wrote:
>> Corrupted disk may return record offset which is larger
>> than node size
>> and cause general protection fault like below:
>
> <snipped>
>
>> This patch add guard for this situation.
>>
>> Signed-off-by: Naohiro Aota <naota@elisp.net>
>
> Nacked. This isn't acceptable. Explained above.

'recoff' is read from disk which can be easily fuzzed to have an
offset that's larger than node_size, no? The kernel shouldn't oops in
that cases so what's the problem with the patch? (The changelog is
terribly vague, though, and needs to be fixed).

Pekka


\
 
 \ /
  Last update: 2011-07-13 08:09    [W:0.101 / U:1.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site