lkml.org 
[lkml]   [2011]   [Jul]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/9] stringify: add HEX_STRING()
    On Wed, 13 Jul 2011 18:05:45 -0300 Mauro Carvalho Chehab wrote:

    > Em 10-07-2011 16:51, Randy Dunlap escreveu:
    > > From: Randy Dunlap <rdunlap@xenotime.net>
    > >
    > > Add HEX_STRING(value) to stringify.h so that drivers can
    > > convert kconfig hex values (without leading "0x") to useful
    > > hex constants.
    > >
    > > Several drivers/media/radio/ drivers need this. I haven't
    > > checked if any other drivers need to do this.
    > >
    > > Alternatively, kconfig could produce hex config symbols with
    > > leading "0x".
    >
    > Hi Randy,
    >
    > After applying patch 1/9 and 2/9 over 3.0-rc7+media patches, I'm
    > now getting this error:
    >
    > drivers/media/radio/radio-aimslab.c:52:1: error: invalid suffix "x20f" on integer constant
    >
    > $ grep 20f .config
    > CONFIG_RADIO_RTRACK_PORT=20f
    >
    > $ gcc --version
    > gcc (GCC) 4.4.5 20110214 (Red Hat 4.4.5-6)
    >
    > Before this patch, this were working (or, at least, weren't producing
    > any error).
    >
    > Perhaps the breakage on your compilation happened due to another
    > patch at the tree? If so, the better would be to apply this patch

    Do you suspect that?

    I built this patch series against the latest linux-next (20110707),
    so it should contain media patches as of that date.

    > series together with the ones that caused the breakage, to avoid
    > bisect troubles.

    Sure, if we know what patch it is (if there indeed is one).

    Can you do:
    $ make drivers/media/radio/radio-aimslab.i

    and tell me what this line contains for you?
    Mine says:

    static int io = 0x20f;


    > >
    > > Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
    > > ---
    > > include/linux/stringify.h | 7 +++++++
    > > 1 file changed, 7 insertions(+)
    > >
    > > NOTE: The other 8 patches are on lkml and linux-media mailing lists.
    > >
    > > --- linux-next-20110707.orig/include/linux/stringify.h
    > > +++ linux-next-20110707/include/linux/stringify.h
    > > @@ -9,4 +9,11 @@
    > > #define __stringify_1(x...) #x
    > > #define __stringify(x...) __stringify_1(x)
    > >
    > > +/*
    > > + * HEX_STRING(value) is useful for CONFIG_ values that are in hex,
    > > + * but kconfig does not put a leading "0x" on them.
    > > + */
    > > +#define HEXSTRINGVALUE(h, value) h##value
    > > +#define HEX_STRING(value) HEXSTRINGVALUE(0x, value)
    > > +
    > > #endif /* !__LINUX_STRINGIFY_H */
    >
    > --


    ---
    ~Randy
    *** Remember to use Documentation/SubmitChecklist when testing your code ***


    \
     
     \ /
      Last update: 2011-07-14 00:07    [W:0.023 / U:33.452 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site