Messages in this thread | | | Date | Wed, 13 Jul 2011 22:41:43 +0200 | From | Greg KH <> | Subject | Re: [stable] [PATCH] FS-Cache: Fix bounds check |
| |
On Wed, Jul 13, 2011 at 12:55:18PM +0100, David Howells wrote: > __fscache_uncache_all_inode_pages() has a loop that goes through page index > numbers go up to (loff_t)-1. This is incorrect. The limit should be > (pgoff_t)-1 as on a 32-bit machine the pgoff_t is smaller than loff_t. > > On m68k the following error is observed: > > fs/fscache/page.c: In function '__fscache_uncache_all_inode_pages': > fs/fscache/page.c:979: warning: comparison is always false due to > limited range of data type > > [Should there be a PGOFF_T_MAX constant defined?] > > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> > Signed-off-by: David Howells <dhowells@redhat.com> > --- > > fs/fscache/page.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-)
<formletter>
This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read Documentation/stable_kernel_rules.txt for how to do this properly.
</formletter>
| |