Messages in this thread | | | Date | Wed, 13 Jul 2011 11:57:38 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH 1/2] efi: merge x86 and ia64 code |
| |
On 07/12/2011 01:24 PM, Matthew Garrett wrote: > We currently have two almost entirely independent EFI implementations in > the kernel, with the x86 code having begun as a modified version of the > ia64 code. Forthcoming ARM platforms will use EFI and there are > experimental ports for some MIPS platforms, so continuing this "One EFI > implementation per architecture" model is likely to result in massive bug > duplication. This patch merges the common elements of the ia64 and x86 > implementations, which should make adding any future platforms a simple > matter of adding setup code and the appropriate stubs for accessing EFI > resources and making calls. > > Signed-off-by: Matthew Garrett <mjg@redhat.com>
Hi Matt,
I get a build error on x86-32:
/home/hpa/kernel/linux-2.6-tip.efi/arch/x86/platform/efi/efi_32.c:43: error: conflicting types for ‘efi_call_phys_prelog’ /home/hpa/kernel/linux-2.6-tip.efi/arch/x86/include/asm/efi.h:73: note: previous declaration of ‘efi_call_phys_prelog’ was here /home/hpa/kernel/linux-2.6-tip.efi/arch/x86/platform/efi/efi_32.c:85: error: conflicting types for ‘efi_call_phys_epilog’ /home/hpa/kernel/linux-2.6-tip.efi/arch/x86/include/asm/efi.h:74: note: previous declaration of ‘efi_call_phys_epilog’ was here make[5]: *** [arch/x86/platform/efi/efi_32.o] Error 1
-hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |