lkml.org 
[lkml]   [2011]   [Jul]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v3] trace: Add x86 irq vector entry/exit tracepoints
On Wed, Jul 13, 2011 at 7:11 AM, Frederic Weisbecker <fweisbec@gmail.com> wrote:
> On Tue, Jul 12, 2011 at 03:08:48PM -0700, Vaibhav Nagarnaik wrote:
>> Breaking this patch up in different small ones makes sense. Can you
>> comment on this proposal for the following trace events?
>>
>> For tracepoints in generic IRQ handlers:
>> 1. trace_timer_vector - takes an enum for BROADCAST, HRTIMER, ONESHOT,
>>    PERIODIC and NOHZ.
>
> Have you read my previous email entirely?
>
> Where I explained we shouldn't use that vector naming outside of low
> level archs, and that those enums break tracing granularity?
>

I was arguing for an enum for this since it is a single contained trace
event for all timers. But you are right, since I'm breaking up the
interrupts in different trace events already, timer interrupts should
also have separate trace events for granularity.

>> 2. trace_irq_work_vector - for IRQ_WORK_VECTOR
>
> trace_irq_work_run() should be enough. And people can add
> trace_irq_work_queue() if they need to one day.
>
>
>> 3. trace_reschedule_vector - for RESCHEDULE_IPI vector
>
> trace_reschedule_interrupt()
>
>
>> 4. trace_call_function_vector - takes an enum for CALL_FUNCTION and
>>    CALL_FUNCTION_SINGLE
>
> Two seperate tracepoints should be better.
>
>
>> Another trace event for arch-specific IRQ vectors which don't have
>> generic event handlers:
>> 5. trace_platform_irq_vector - takes an enum, which is defined in
>>    asm/irq.h for each platform. This is traced in arch-specific files
>>    only.
>
> Yep. For this perhaps an enum can make sense.
>
> Thanks.
>

I will create and post the patch series soon.


Thanks

Vaibhav Nagarnaik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-07-13 20:21    [from the cache]
©2003-2011 Jasper Spaans