Messages in this thread | | | Date | Wed, 13 Jul 2011 14:20:55 +0100 | From | Alan Cox <> | Subject | Re: [PATCH] Input: cy8ctmg110_ts - set reset_pin and irq_pin from platform data |
| |
On Wed, 13 Jul 2011 21:06:59 +0800 Axel Lin <axel.lin@gmail.com> wrote:
> The implementation in cy8ctmg110_probe() does not properly set reset_pin > and irq_pin from platform data. Let's fix it. > > Signed-off-by: Axel Lin <axel.lin@gmail.com> > --- > Current implementation returns -ENODEV if no pdata available. > But it does not use the information from pdata. > I think currently the driver does not work because both ts->reset_pin and ts->irq_pin are 0, then gpio_request with ts->irq_pin will fail. > > Just found this bug while reading the code. > I don't have this hardware. I appreciate if someone can test it.
Looks right, but I'm likewise unable to test it as I no longer have access to a device using it.
Alan
| |