Messages in this thread | | | Date | Tue, 12 Jul 2011 17:27:33 -0700 | Subject | ftrace: trace_pipe_raw, blocking, and splice() | From | Slava Pestov <> |
| |
Hi ftrace users,
I notice that tracing_buffers_splice_read() has this comment in it around line 3900:
/* TODO: block */
Was the original intention that reading from trace_pipe_raw with tracing enabled should block if there is no data available, rather than returning with end of file?
If so, I suggest adding a new trace_raw special file which behaves like the current trace_pipe_raw (return 0 on EOF). Then we'd change trace_pipe_raw to block on EOF.
Does this sound reasonable or is breaking APIs like this unacceptable?
Slava
| |