lkml.org 
[lkml]   [2011]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] modpost: Fix modpost's license checking V2
    From
    On Tue, Jul 12, 2011 at 03:00, Alessio Igor Bogani <abogani@kernel.org> wrote:
    > +#define SEC_NAME_MATCH(name, str) (strncmp(name, str, strlen(str) - 1) == 0)

    Surely you meant strlen() or sizeof() - 1, not strlen() - 1?

    > + if (!is_vmlinux(mod->name) && strncmp(symname, "__ksymtab", 9) == 0)

    Same strncmp pattern here. BTW, your macro is the strstarts()
    function in include/linux/string.h.

    Anders


    \
     
     \ /
      Last update: 2011-07-12 20:05    [W:0.019 / U:2.124 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site