lkml.org 
[lkml]   [2011]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: Fix memory leak of init_vdso_vars()

* wzt wzt <wzt.wzt@gmail.com> wrote:

> maybe, we can just panic() when kmalloc failed instead of add a new
> GFP_PANIC.
>
> new patch will coming soon.
>
> On Fri, Jul 8, 2011 at 2:33 AM, Andi Kleen <ak@linux.intel.com> wrote:
> > When you run out of memory at early system boot (this is early
> > system boot only) the system is toast anyways. There's no way
> > to recover.
> >
> > I would just add a few GFP_PANICs and then drop the error paths.

That's a very sloppy way of doing it: should anyone ever want to
reuse this function *not* in an init path (which is a future
possibility with the vdso) it will have a nasty panic() embedded in
it ...

Thanks,

Ingo


\
 
 \ /
  Last update: 2011-07-11 12:07    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog