Messages in this thread Patch in this message | | | From | Jim Cromie <> | Subject | [PATCH 07/21] dynamic_debug: return int from ddebug_change | Date | Mon, 11 Jul 2011 01:46:42 -0600 |
| |
Alter ddebug_change to return number of matches found for query/rule. This lets caller know whether rule applied, and potentially what to do next.
Signed-off-by: Jim Cromie <jim.cromie@gmail.com> --- lib/dynamic_debug.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index bbee0aa..de2a679 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -102,8 +102,8 @@ static char *ddebug_describe_flags(struct _ddebug *dp, char *buf, * the user which ddebug's were changed, or whether none * were matched. */ -static void ddebug_change(const struct ddebug_query *query, - unsigned int flags, unsigned int mask) +static int ddebug_change(const struct ddebug_query *query, + unsigned int flags, unsigned int mask) { int i; struct ddebug_table *dt; @@ -167,8 +167,7 @@ static void ddebug_change(const struct ddebug_query *query, } mutex_unlock(&ddebug_lock); - if (!nfound && verbose) - pr_info("no matches for query\n"); + return nfound; } /* @@ -420,6 +419,7 @@ static int ddebug_exec_query(char *query_string) #define MAXWORDS 9 int nwords; char *words[MAXWORDS]; + int nfound; nwords = ddebug_tokenize(query_string, words, MAXWORDS); if (nwords <= 0) @@ -430,7 +430,7 @@ static int ddebug_exec_query(char *query_string) return -EINVAL; /* actually go and implement the change */ - ddebug_change(&query, flags, mask); + nfound = ddebug_change(&query, flags, mask); return 0; } -- 1.7.4.1
| |