lkml.org 
[lkml]   [2011]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] e_powersaver: Add sanity checks to code provided by VIA
    Patch from VIA is forcing "e_powersaver" to accept any processor >=A, 
    but code supports only A and D.
    Patch from VIA is forcing "e_powersaver" to support new brand, but code
    was intended for 2 bits only.
    Looks like model D is using 8 bits for brand. Compensate.

    Thanks to Axel Lin for pointing it out!

    Signed-off-by: Rafał Bilski <rafalbilski@interia.pl>

    ---
    drivers/cpufreq/e_powersaver.c | 15 ++++++++++++---
    1 files changed, 12 insertions(+), 3 deletions(-)

    diff --git a/drivers/cpufreq/e_powersaver.c b/drivers/cpufreq/e_powersaver.c
    index 35a257d..7883ffa 100644
    --- a/drivers/cpufreq/e_powersaver.c
    +++ b/drivers/cpufreq/e_powersaver.c
    @@ -179,9 +179,13 @@ static int eps_cpu_init(struct cpufreq_policy *policy)
    break;
    case 13:
    rdmsr(0x1154, lo, hi);
    - brand = (((lo >> 4) ^ (lo >> 2))) & 0x000000ff;
    + brand = (((lo >> 4) ^ (lo >> 2))) & 0xff;
    printk(KERN_CONT "Model D ");
    break;
    + default:
    + printk(KERN_CONT "unknown processor\n");
    + return -ENODEV;
    + break;
    }

    switch (brand) {
    @@ -194,14 +198,19 @@ static int eps_cpu_init(struct cpufreq_policy *policy)
    case EPS_BRAND_EDEN:
    printk(KERN_CONT "Eden\n");
    break;
    + case EPS_BRAND_C3:
    + printk(KERN_CONT "C3\n");
    + return -ENODEV;
    + break;
    case EPS_BRAND_C7D:
    printk(KERN_CONT "C7-D\n");
    break;
    - case EPS_BRAND_C3:
    - printk(KERN_CONT "C3\n");
    + default:
    + printk(KERN_CONT "unsupported brand\n");
    return -ENODEV;
    break;
    }
    +
    /* Enable Enhanced PowerSaver */
    rdmsrl(MSR_IA32_MISC_ENABLE, val);
    if (!(val & MSR_IA32_MISC_ENABLE_ENHANCED_SPEEDSTEP)) {
    --
    1.7.6


    ----------------------------------------------------------------
    Znajdz samochod idealny dla siebie!
    Szukaj >> http://linkint.pl/f29e2
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2011-07-12 00:11    [W:0.022 / U:13.204 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site