lkml.org 
[lkml]   [2011]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] PTI implicit declaration fix.
From
On Mon, Jul 11, 2011 at 18:10, J Freyensee
<james_p_freyensee@linux.intel.com> wrote:
> On 07/09/2011 01:08 AM, Geert Uytterhoeven wrote:
>> On Fri, Jul 8, 2011 at 23:34,<james_p_freyensee@linux.intel.com>  wrote:
>>>
>>> From: J Freyensee<james_p_freyensee@linux.intel.com>
>>>
>>> In a certain compile configuration, functions like
>>> 'kmalloc' and 'copy_from_user' were coming up as
>>> implicit errors.  This patch adds slab.h and
>>> uaccess.h to the driver.
>>>
>>> Reported-by: Geert Uytterhoeven<geert@linux-m68k.org>
>>> Acked-by: Geert Uytterhoeven<geert@linux-m68k.org>
>>
>> Please don't add "Acked-by" lines before people have ack'ed your patches.
>>
>
> Okay...so should I re-send this patch out without the Acked-by in it? Or is
> it okay this time and next time please do this?

It's OK for now. It's a trivial patch anyway.

>>> Signed-off-by: J Freyensee<james_p_freyensee@linux.intel.com>
>>> ---
>>>  drivers/misc/pti.c |    2 ++
>>>  1 files changed, 2 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/drivers/misc/pti.c b/drivers/misc/pti.c
>>> index 8653bd0..4ba4e5f 100644
>>> --- a/drivers/misc/pti.c
>>> +++ b/drivers/misc/pti.c
>>> @@ -22,6 +22,8 @@
>>>  */
>>>
>>>  #include<linux/init.h>
>>> +#include<linux/slab.h>
>>> +#include<linux/uaccess.h>
>>>  #include<linux/sched.h>
>>>  #include<linux/interrupt.h>
>>>  #include<linux/console.h>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-07-11 18:59    [W:0.040 / U:8.992 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site