[lkml]   [2011]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2 3/8] x86-64: Allow alternative patching in the vDSO
On Mon, Jul 11, 2011 at 4:41 AM, Rakib Mullick <> wrote:
> On Sun, Jul 10, 2011 at 9:22 AM, Andy Lutomirski <> wrote:

>> +static void patch_vdso(void *vdso, size_t len)
> I think, patch_vdso should mark with __init. Since it's been only
> called from an __init function. We might hit a section mismatch, even
> if we don't hit section mismatch, the will function get removed after
> system boot - saves some .text size.

Sure. It won't make any difference, because my compiler at least is
smart enough to inline the whole function into init_vdso_vars, but
it's the right thing to do anyway.

>> +       return;  /* nothing to patch */
> If there's nothing to patch, I think (perhaps) - it would be nice to
> let user know through printk.

Will do. I verified it myself by dumping the vdso image from memory
and confirming that it got patched correctly, but if the code ever
bitrots it'll be nice to have the warning.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2011-07-11 16:23    [W:0.038 / U:1.888 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site