lkml.org 
[lkml]   [2011]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 1/2] x86-64: Simplify cpu_has_invlpg
    From
    On Sun, Jul 10, 2011 at 2:18 PM, H. Peter Anvin <hpa@zytor.com> wrote:
    > On 07/10/2011 06:53 AM, Brian Gerst wrote:
    >> Define CONFIG_X86_INVLPG for 64-bit too, which simplifies the code.
    >>
    >> Signed-off-by: Brian Gerst <brgerst@gmail.com>
    >
    > I think a much better way to do this kind of stuff is to define
    > Linux-specific CPU feature bits (which we already have quite a few of).
    >  That way they fall into the same mechanism as everything else that has
    > switches on CPU features, we can use alternatives, and so on.

    I don't think it's worth getting too fancy with this. Even if you
    used alternatives, you'd want the config option to eliminate the
    alternative when compiling for 486+.

    --
    Brian Gerst
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-07-11 13:53    [W:0.031 / U:0.088 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site