[lkml]   [2011]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH 2/2] kconfig/nconf: prevent segfault on empty menu
nconf does not check the validity of the current menu when help is requested
(with either <F2>, '?' or 'h'). This leads to a NULL pointer dereference when an
empty menu is encountered.

The following reduced testcase exposes the problem:

config DEP

menu "FOO"

config BAR
bool "BAR"
depends on DEP


Issue will happen when entering menu "FOO" and requesting help.

nconf is the only front-end which do not filter the validity of the current
menu. Such filter can not really happen beforehand as other key which does not
deals with the current menu might be entered by the user, so just bails out
earlier if we encounter an invalid menu.

Cc: Nir Tzachar <>
Cc: Andrej Gelenberg <>
Reported-by: Andrej Gelenberg <>
Signed-off-by: Arnaud Lacombe <>
scripts/kconfig/nconf.c | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/scripts/kconfig/nconf.c b/scripts/kconfig/nconf.c
index 24fc79a..eb9e49d 100644
--- a/scripts/kconfig/nconf.c
+++ b/scripts/kconfig/nconf.c
@@ -1222,7 +1222,12 @@ static void conf_message_callback(const char *fmt, va_list ap)

static void show_help(struct menu *menu)
- struct gstr help = str_new();
+ struct gstr help;
+ if (!menu)
+ return;
+ help = str_new();
menu_get_ext_help(menu, &help);
show_scroll_win(main_window, _(menu_get_prompt(menu)), str_get(&help));

 \ /
  Last update: 2011-07-10 09:29    [from the cache]
©2003-2014 Jasper Spaans. hosted at Digital Ocean