[lkml]   [2011]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] regulator: tps65910: Fix array access out of bounds bug
    On Mon, Jul 11, 2011 at 09:57:43AM +0800, Axel Lin wrote:
    > For tps65910, the number of regulator is 13. ( ARRAY_SIZE(tps65910_regs) is 13)
    > For tps65911, the number of regulator is 12. ( ARRAY_SIZE(tps65911_regs) is 12)
    > If we are using this driver for tps65911,
    > we hit array access out of bounds bug in tps65910_probe() because
    > current implementation always assume the number of regulator is 13 and
    > thus it will access tps65911_regs[12].
    > Fix it by setting correct num_regulators for both chips in tps65910_probe(),
    > and allocated neccessay memory accordingly.

    Acked-by: Mark Brown <>

    This patch would be much less invasive if you didn't change to
    allocating everything dynamically - you could fix the out of bounds
    issues by just limiting the number of times we go round the array.

     \ /
      Last update: 2011-07-11 05:51    [W:0.018 / U:34.372 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site