lkml.org 
[lkml]   [2011]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: do_signal: simplify the TS_RESTORE_SIGMASK logic
On Sun, Jul 10, 2011 at 08:22:03PM +0200, Oleg Nesterov wrote:

> 2. do_signal() also clears TS_RESTORE_SIGMASK if handle_signal()
> succeeds.
>
> We can move this to setup_rt_frame() as well, this avoids the
> unnecessary checks and makes the logic more clear.


> + current_thread_info()->status &= ~TS_RESTORE_SIGMASK;
> return ret;

This is broken. If setup_rt_frame() fails, you don't want to do that.


\
 
 \ /
  Last update: 2011-07-10 23:11    [W:0.044 / U:25.836 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site