lkml.org 
[lkml]   [2011]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectAW: [PATCH] Staging: comedi: Fixing style issues




----- Ursprüngliche Mail ----
> Von: Greg KH <greg@kroah.com>
> An: markpearson_de@yahoo.de
> CC: abbotti@mev.co.uk; fmhess@users.sourceforge.net;
>devel@driverdev.osuosl.org; linux-kernel@vger.kernel.org
> Gesendet: Sonntag, den 10. Juli 2011, 20:26:34 Uhr
> Betreff: Re: [PATCH] Staging: comedi: Fixing style issues
>
> On Sun, Jul 10, 2011 at 08:12:46PM +0200, markpearson_de@yahoo.de wrote:
> > From: Mark Pearson <markpearson_de@yahoo.de>
> >
> > comedi_fops.c : Warning that externs should be avoided in .c files.
> > A forward function decleration was declared extern
> > although it was only used internally. Changed
> > decleration to static.
> > comedi.h : Fixed warning that storage class should be a the
> > begining of declerations.
> >
> > Lindent ran on both files.
> >
> > Ignore previous patch - forgot to add signed off by.
>
> Care to break this up into a set of "only do one thing per patch"
> series? That way it's reviewable.
>
> Also, running Lindent is usually a very bad idea on files that have been
> around for a while now. It causes a lot of unneeded churn, please just
> make the minor changes needed to be checkpatch.pl clean by hand.
>
> thanks,
>
> greg k-h
>

No problem Greg. I've submitted the patches for the two files again as a
one-thing-per-patch and left out the Lindent.

Thanks for the feedback.

Cheers, Mark.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-07-10 21:25    [W:0.045 / U:2.692 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site