Messages in this thread | | | Date | Sun, 10 Jul 2011 11:26:34 -0700 | From | Greg KH <> | Subject | Re: [PATCH] Staging: comedi: Fixing style issues |
| |
On Sun, Jul 10, 2011 at 08:12:46PM +0200, markpearson_de@yahoo.de wrote: > From: Mark Pearson <markpearson_de@yahoo.de> > > comedi_fops.c : Warning that externs should be avoided in .c files. > A forward function decleration was declared extern > although it was only used internally. Changed > decleration to static. > comedi.h : Fixed warning that storage class should be a the > begining of declerations. > > Lindent ran on both files. > > Ignore previous patch - forgot to add signed off by.
Care to break this up into a set of "only do one thing per patch" series? That way it's reviewable.
Also, running Lindent is usually a very bad idea on files that have been around for a while now. It causes a lot of unneeded churn, please just make the minor changes needed to be checkpatch.pl clean by hand.
thanks,
greg k-h
| |