lkml.org 
[lkml]   [2011]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Avoid Wunused-but-set warning
    On Sun, 10 Jul 2011 12:49:20 -0400 Arnaud Lacombe wrote:

    > Hi,
    >
    > On Sun, Jul 10, 2011 at 12:28 PM, Pekka Enberg <penberg@kernel.org> wrote:
    > > On Sun, Jul 10, 2011 at 7:24 PM, Arnaud Lacombe <lacombar@gmail.com> wrote:
    > >> Hi,
    > >>
    > >> On Sun, Jul 10, 2011 at 12:16 PM, Américo Wang <xiyou.wangcong@gmail.com> wrote:
    > >>> On Sun, Jul 10, 2011 at 12:24 AM, Raghavendra D Prabhu
    > >>> <rprabhu@wnohang.net> wrote:
    > >>>> Hi,
    > >>>>    I am seeing Wunused-but-set warning while make nconfig.  Looks like
    > >>>>    active_menu is not used. Removing it fixes the warning.
    > >>>>
    > >>>> Signed-off-by: Raghavendra D Prabhu <rprabhu@wnohang.net>
    > >>>
    > >>> Acked-by: WANG Cong <xiyou.wangcong@gmail.com>
    > >>>
    > >> Out of curiosity, what is your status to ACK such patch ?
    > >
    > > What kind of status do you need to ACK such a simple patch?
    > >
    > As per Documentation/SubmittingPatches:
    >
    > <<
    > 13) When to use Acked-by: and Cc:
    > The Signed-off-by: tag indicates that the signer was involved in the
    > development of the patch, or that he/she was in the patch's delivery path.
    >
    > If a person was not directly involved in the preparation or handling of a
    > patch but wishes to signify and record their approval of it then they can
    > arrange to have an Acked-by: line added to the patch's changelog.
    >
    > Acked-by: is often used by the maintainer of the affected code when that
    > maintainer neither contributed to nor forwarded the patch.
    > >>
    >
    > That said, it is not a strong requirement... unfortunately. So, let's
    > have some fun and go ACK thousand of trivial patch just to generate
    > traffic on the LKML and give myself self-importance :-)

    Acked-by: is mostly used as a weak version of Reviewed-by:
    and the "definition" in SubmittingPatches is not accurate IMO.
    I.e., it can be used by anyone.

    ---
    ~Randy
    *** Remember to use Documentation/SubmitChecklist when testing your code ***
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-07-10 20:05    [W:0.030 / U:33.192 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site