[lkml]   [2011]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] Avoid Wunused-but-set warning

On Sun, Jul 10, 2011 at 12:28 PM, Pekka Enberg <> wrote:
> On Sun, Jul 10, 2011 at 7:24 PM, Arnaud Lacombe <> wrote:
>> Hi,
>> On Sun, Jul 10, 2011 at 12:16 PM, Américo Wang <> wrote:
>>> On Sun, Jul 10, 2011 at 12:24 AM, Raghavendra D Prabhu
>>> <> wrote:
>>>> Hi,
>>>>    I am seeing Wunused-but-set warning while make nconfig.  Looks like
>>>>    active_menu is not used. Removing it fixes the warning.
>>>> Signed-off-by: Raghavendra D Prabhu <>
>>> Acked-by: WANG Cong <>
>> Out of curiosity, what is your status to ACK such patch ?
> What kind of status do you need to ACK such a simple patch?
As per Documentation/SubmittingPatches:

13) When to use Acked-by: and Cc:
The Signed-off-by: tag indicates that the signer was involved in the
development of the patch, or that he/she was in the patch's delivery path.

If a person was not directly involved in the preparation or handling of a
patch but wishes to signify and record their approval of it then they can
arrange to have an Acked-by: line added to the patch's changelog.

Acked-by: is often used by the maintainer of the affected code when that
maintainer neither contributed to nor forwarded the patch.

That said, it is not a strong requirement... unfortunately. So, let's
have some fun and go ACK thousand of trivial patch just to generate
traffic on the LKML and give myself self-importance :-)

- Arnaud
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2011-07-10 18:51    [W:0.081 / U:0.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site