lkml.org 
[lkml]   [2011]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] USB: EHCI: Move sysfs related bits into ehci-sysfs.c
    On Fri, 1 Jul 2011, Kirill Smelkov wrote:

    > > > The checking is not a priority for me here, so if you think it's better not
    > > > to check or do it under #ifdef - let's do it. Though of course we all
    > > > have our preferences :)
    > >
    > > Yes, it's just a matter of taste. I prefer to add as little code as
    > > possible for a feature that won't be used much.
    >
    >
    > Look: we have 3 choices: to check or not to check, and if we are
    > checking whether it is under #ifdef DEBUG. Not checking at all makes the
    > code inconsistent with the check in periodic_usecs(). Then, if we are
    > checking, putting it under #ifdef DEBUG goes against minimum complexity /
    > "to add as little code as possible ...". It looks the good balance is to
    > leave the checking as is module you above remark.
    >
    > And with the above-mentioned correction and comments inspired by Sarah's
    > concern I'm resending the whole series as v3. Can we do it this way,
    > please?

    Okay, you can add my Acked-by to the 2/2 patch.

    Alan Stern



    \
     
     \ /
      Last update: 2011-07-01 17:43    [W:0.025 / U:0.744 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site