lkml.org 
[lkml]   [2011]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH][RFC] Sparc: Remove trigraph in die_if_kernel() message.
From
From: Jesper Juhl <jj@chaosbits.net>
Date: Tue, 7 Jun 2011 16:38:19 +0200 (CEST)

> In arch/sparc/kernel/traps_32.c::do_priv_instruction() we have this:
>
> die_if_kernel("Penguin instruction from Penguin mode??!?!", regs);
>
> If I'm not mistaken, that "??!" will be taken as a trigraph for "|" by the
> preprocessor, so the final string will end up either as
> "Penguin instruction from Penguin mode|?!"
> which I assume is not what we want, or as the correct string but with a
> warning about an ignored trigraph which I assume we don't want either. So,
> in order to elliminate the trigraph but keep the original string intact I
> changed it to
>
> die_if_kernel("Penguin instruction from Penguin mode?""?!?!", regs);
>
> I've tested with a small test program on my x86-64 host and it behaves as
> I would expect, but I've not tested the actual code in
> arch/sparc/kernel/traps_32.c since I have no way to compile for sparc
> (which is why I submit this as a [RFC] patch).
>
> Please take a look and apply if you agree :-)
>
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>

Applied, thanks Jesper :-)


\
 
 \ /
  Last update: 2011-06-10 01:03    [W:0.145 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site