Messages in this thread | | | Date | Thu, 09 Jun 2011 15:59:43 -0700 (PDT) | Subject | Re: [PATCH][RFC] Sparc: Remove trigraph in die_if_kernel() message. | From | David Miller <> |
| |
From: Jesper Juhl <jj@chaosbits.net> Date: Tue, 7 Jun 2011 16:38:19 +0200 (CEST)
> In arch/sparc/kernel/traps_32.c::do_priv_instruction() we have this: > > die_if_kernel("Penguin instruction from Penguin mode??!?!", regs); > > If I'm not mistaken, that "??!" will be taken as a trigraph for "|" by the > preprocessor, so the final string will end up either as > "Penguin instruction from Penguin mode|?!" > which I assume is not what we want, or as the correct string but with a > warning about an ignored trigraph which I assume we don't want either. So, > in order to elliminate the trigraph but keep the original string intact I > changed it to > > die_if_kernel("Penguin instruction from Penguin mode?""?!?!", regs); > > I've tested with a small test program on my x86-64 host and it behaves as > I would expect, but I've not tested the actual code in > arch/sparc/kernel/traps_32.c since I have no way to compile for sparc > (which is why I submit this as a [RFC] patch). > > Please take a look and apply if you agree :-) > > Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Applied, thanks Jesper :-)
| |