lkml.org 
[lkml]   [2011]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRE: [PATCH v2] usb:dummy_hcd: Force FS device connection according to module parameter
On Thu, 9 Jun 2011, Tanya Brokhman wrote:

> > > + if (!mod_data.is_high_speed && mod_data.is_super_speed)
> > > + return -EINVAL;
> >
> > Print an error message in the log so that the user will know why the
> > failure occurred.
> >
>
> But when the module fails to load the message sais that it's invalid
> parameter (or something like that). That's why I thought it will be enough.

Oh yes, that's true.

> You mean to add something that explains WHY these values are wrong?

That's what I had in mind. But "invalid parameter" is probably good
enough, since these are the _only_ parameters. :-) So this part is
okay as it stands.

Alan Stern



\
 
 \ /
  Last update: 2011-06-09 23:25    [W:0.072 / U:1.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site