Messages in this thread | | | Date | Thu, 9 Jun 2011 07:51:59 -0700 | From | Mandeep Singh Baines <> | Subject | Re: [PATCH 1/4] watchdog: fix rounding issues in get_sample_period() |
| |
Don Zickus (dzickus@redhat.com) wrote: > On Thu, May 19, 2011 at 09:26:31AM -0700, Mandeep Singh Baines wrote: > > Don Zickus (dzickus@redhat.com) wrote: > > > On Mon, May 16, 2011 at 04:34:58PM -0700, Mandeep Singh Baines wrote: > > > > In get_sample_period(), softlockup_thresh is integer divided by 5 before > > > > the multiplication by NSEC_PER_SEC. This results in softlockup_thresh > > > > being rounded down to the nearest integer multiple of 5. > > > > > > > > For example, a softlockup_thresh of 4 rounds down to 0. > > > > > > Mandeep, > > > > > > Thanks for the patches. Unfortunately, I am taking some time off so I'll > > > shephard these patches when I get back. For the most part they look fine, > > > aside from Ingo's comments. > > > > > > > No problem. Enjoy your time off:) > > > > Ingo, since Don is out, would you mind acking the patches (assuming you're > > happy). It simplifies pushing these patches into our local ChromiumOS tree > > if I have an upstream ack. > > Hi Mandeep, > > It looks like Ingo took most of your patches. Is there any outstanding > ones that didn't make it that you see? >
Hi Don,
Thanks for following up. All the patches are now in.
I am working on a few new NMI issues so I'll be sending out a few patches in a day or so. I've committed one critical fix to our 2.6.32 tree and am now working on forward-porting it to tip/master:
http://git.chromium.org/gitweb/?p=chromiumos/third_party/kernel.git;a=commitdiff;h=2a825f5f38f24e655dd655253eaaa5a82460a43e;hp=09ecdd5b43b9df930efd51a3fe317c18907a6c2d
Regards, Mandeep
> Cheers, > Don
| |