lkml.org 
[lkml]   [2011]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 2/8] mm: memcg-aware global reclaim
    On Thu, Jun 09, 2011 at 03:12:03PM +0200, Michal Hocko wrote:
    > On Wed 01-06-11 08:25:13, Johannes Weiner wrote:
    > [...]
    >
    > Just a minor thing. I am really slow at reviewing these days due to
    > other work that has to be done...
    >
    > > +struct mem_cgroup *mem_cgroup_hierarchy_walk(struct mem_cgroup *root,
    > > + struct mem_cgroup *prev)
    > > +{
    > > + struct mem_cgroup *mem;
    >
    > You want mem = NULL here because you might end up using it unitialized
    > AFAICS (css_get_next returns with NULL).

    Thanks for pointing it out. It was introduced when I switched from
    using @prev to continue the search to using root->last_scanned_child.

    It's fixed now.


    \
     
     \ /
      Last update: 2011-06-09 15:49    [W:0.041 / U:0.252 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site