lkml.org 
[lkml]   [2011]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] sched: remove resetting exec_start in put_prev_task_rt()
From
Date
On Thu, 2011-06-02 at 16:04 +0800, Yong Zhang wrote:
> On Wed, Jun 1, 2011 at 10:03 PM, Hillf Danton <dhillf@gmail.com> wrote:
> > Resetting exec_start, after updated in update_curr_rt(), could open window for
> > messing up the subsequent computations of delta_exec of the given task.
>
> I can't see how could this happen. what kind of 'subsequent computations'
> do you mean?

I still don't see a race.

Hilf, if you still believe there's a race here, can you explain it in
detail. Do something like:

CPU0 CPU1
---- ----
do_something;
does_something_not_expected;
continue_something;

Obviously changing what those "somethings" are. That way we can visually
see what you are trying to say.

>
> But because exec_start will be reset by _pick_next_task_rt()/set_curr_task_rt(),
> you patch is ok. IMHO it is not critical, it's just cleanup instead.

I disagree. Yes the exec_start is reset there, but I like the fact that
it's 0 when not running.

-- Steve




\
 
 \ /
  Last update: 2011-06-09 14:37    [W:0.150 / U:1.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site