Messages in this thread | | | Subject | Re: [PATCH 14/15] gma500: nuke the PSB debug stuff | From | Dave Airlie <> | Date | Thu, 09 Jun 2011 20:36:51 +1000 |
| |
On Thu, 2011-06-09 at 09:11 +0100, Alan Cox wrote: > On Thu, 9 Jun 2011 03:10:03 +0200 > Patrik Jakobsson <patrik.r.jakobsson@gmail.com> wrote: > > > Hi Alan > > > > Just a thought. Shouldn't we use the DRM macros for printing debug info? > > Linux has perfectly good printing functions and using them means we can > use dev_dbg() which supports things like nice runtime switching.
You mean like the drm debug functions runtime switching? that predated the kernel ones and nobody ever ported :-)
Though if psb wants to be different to other drm drivers it can lead the way, though it'll be a total nightmare for all the people who follow documentation on how to debug drm drivers using drm.debug=1,2,4,8. for various code paths.
Dave.
| |