lkml.org 
[lkml]   [2011]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: Fix sys_call_table type in asm/syscall.h

* Andi Kleen <andi@firstfloor.org> wrote:

> > There's an obvious problem with this patch, please fix it and resend.
>
> Nothing obvious to me. Can you be more specific?

Sure, a trivial git grep of the sys_call_ptr_t typedef you added to
syscall.h shows:

~/tip> git grep sys_call_ptr_t
arch/um/sys-x86_64/syscall_table.c:typedef void (*sys_call_ptr_t)(void);
arch/x86/include/asm/syscall.h:typedef void (*sys_call_ptr_t)(void);
arch/x86/kernel/syscall_64.c:typedef void (*sys_call_ptr_t)(void);

So you've now added a third typedef in addition to the two existing
ones. We obivously only want one in the kernel - the one you added to
the header file.

Thanks,

Ingo


\
 
 \ /
  Last update: 2011-06-08 10:27    [from the cache]
©2003-2011 Jasper Spaans