lkml.org 
[lkml]   [2011]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 3.0-rc2-tip 13/22] 13: uprobes: Handing int3 and singlestep exception.


On Tue, Jun 07, 2011 at 06:30:51PM +0530, Srikar Dronamraju wrote:
> +/*
> + * uprobe_post_notifier gets called in interrupt context.
> + * It completes the single step operation.
> + */
> +int uprobe_post_notifier(struct pt_regs *regs)
> +{
> + struct uprobe *uprobe;
> + struct uprobe_task *utask;
> +
> + if (!current->mm || !current->utask || !current->utask->active_uprobe)
> + /* task is currently not uprobed */
> + return 0;
> +
> + utask = current->utask;
> + uprobe = utask->active_uprobe;
> + if (!uprobe)
> + return 0;
> +
> + set_thread_flag(TIF_UPROBE);
> + return 1;
> +}

Looks like this can be simplified. If current->utask->active_uprobe is
non-null then surely the assignment to uprobe will be too?


--
steve



\
 
 \ /
  Last update: 2011-06-09 00:15    [from the cache]
©2003-2011 Jasper Spaans