lkml.org 
[lkml]   [2011]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [debug patch] printk: Add a printk killswitch to robustify NMI watchdog messages
On Wed, Jun 8, 2011 at 1:32 PM, Peter Zijlstra <peterz@infradead.org> wrote:
>
> atomic_down() is a tad iffy, it would have to wait for an actual
> semaphore owner, which might sleep etc.. So I skipped it.

I think sleeping would be fine: the "atomic" part is about the code
the semaphore protects, not about the down() itself.

But the way you made the semantics be (caller has to disable
interrupts) for the other helpers, that doesn't really work.

Linus


\
 
 \ /
  Last update: 2011-06-08 22:57    [W:1.985 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site