Messages in this thread | | | Date | Wed, 8 Jun 2011 12:47:45 -0700 | From | "Paul E. McKenney" <> | Subject | Re: [PATCH tip/core/rcu 18/28] jbd2,rcu: Convert call_rcu(free_devcache) to kfree_rcu() |
| |
On Wed, Jun 08, 2011 at 09:34:31PM +0200, Jan Kara wrote: > On Wed 08-06-11 12:29:57, Paul E. McKenney wrote: > > From: Lai Jiangshan <laijs@cn.fujitsu.com> > > > > The rcu callback free_devcache() just calls a kfree(), > > so we use kfree_rcu() instead of the call_rcu(free_devcache). > > > > Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com> > > Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> > > Cc: Andrew Morton <akpm@linux-foundation.org> > > Cc: Jan Kara <jack@suse.cz> > > Reviewed-by: Josh Triplett <josh@joshtriplett.org> > Acked-by: Jan Kara <jack@suse.cz>
Thank you, Jan!
Thanx, Paul
> Honza > > --- > > fs/jbd2/journal.c | 7 +------ > > 1 files changed, 1 insertions(+), 6 deletions(-) > > > > diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c > > index e0ec3db..13fb464 100644 > > --- a/fs/jbd2/journal.c > > +++ b/fs/jbd2/journal.c > > @@ -2390,11 +2390,6 @@ struct devname_cache { > > static struct devname_cache *devcache[1 << CACHE_SIZE_BITS]; > > static DEFINE_SPINLOCK(devname_cache_lock); > > > > -static void free_devcache(struct rcu_head *rcu) > > -{ > > - kfree(rcu); > > -} > > - > > const char *jbd2_dev_to_name(dev_t device) > > { > > int i = hash_32(device, CACHE_SIZE_BITS); > > @@ -2423,7 +2418,7 @@ const char *jbd2_dev_to_name(dev_t device) > > spin_unlock(&devname_cache_lock); > > return ret; > > } > > - call_rcu(&devcache[i]->rcu, free_devcache); > > + kfree_rcu(devcache[i], rcu); > > } > > devcache[i] = new_dev; > > devcache[i]->device = device; > > -- > > 1.7.3.2 > > > -- > Jan Kara <jack@suse.cz> > SUSE Labs, CR > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
| |