lkml.org 
[lkml]   [2011]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v4 1/6] GPIO: pca953x.c: Fix IRQ support.
    Date
    It seems that in the normal case, IRQ_NOREQUEST needs to be explicitly
    cleared, otherwise claiming the interrupt fails.
    In the case of sparse interrupts, the descriptor needs to be allocated
    first.

    Signed-off-by: David Jander <david@protonic.nl>
    ---
    drivers/gpio/pca953x.c | 6 +++++-
    1 files changed, 5 insertions(+), 1 deletions(-)

    diff --git a/drivers/gpio/pca953x.c b/drivers/gpio/pca953x.c
    index 0451d7a..b31f881 100644
    --- a/drivers/gpio/pca953x.c
    +++ b/drivers/gpio/pca953x.c
    @@ -474,12 +474,16 @@ static int pca953x_irq_setup(struct pca953x_chip *chip,
    * this purpose.
    */
    chip->irq_stat &= chip->reg_direction;
    - chip->irq_base = pdata->irq_base;
    mutex_init(&chip->irq_lock);

    + chip->irq_base = irq_alloc_descs(-1, pdata->irq_base, chip->gpio_chip.ngpio, -1);
    + if (chip->irq_base < 0)
    + goto out_failed;
    +
    for (lvl = 0; lvl < chip->gpio_chip.ngpio; lvl++) {
    int irq = lvl + chip->irq_base;

    + irq_clear_status_flags(irq, IRQ_NOREQUEST);
    irq_set_chip_data(irq, chip);
    irq_set_chip_and_handler(irq, &pca953x_irq_chip,
    handle_simple_irq);
    --
    1.7.4.1


    \
     
     \ /
      Last update: 2011-06-08 15:23    [W:0.020 / U:0.668 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site