Messages in this thread | | | From | Vaibhav Nagarnaik <> | Date | Tue, 7 Jun 2011 16:30:11 -0700 | Subject | Re: [PATCH] trace: Set oom_score_adj to maximum for ring buffer allocating process |
| |
On Tue, Jun 7, 2011 at 4:07 PM, Steven Rostedt <rostedt@goodmis.org> wrote: > > Hi Vaibhav, > > I'm going though patches for v3.1 now. Where are we on this issue. I > still don't really like the ideal of having the kernel set the oom > policy by default. But I'm totally fine with changing the allocations > for NORETRY. > > If you switch it to NORETRY, do you still have the issues you were > seeing? You could also add userspace helpers that would set the oom > policy of things accessing the ring buffer. > > Either have a script that updates the ring buffer size and sets the oom > policy, or have a library with a helper routine. > > Would those be fine for you? > > -- Steve > I understand your hesitation to change the kernel oom policy for allocating the ring buffer. I am fine with just using __GFP_NORETRY for allocation calls to fail more gracefully. It works for most of the use cases I encounter.
We will make changes to our internal tools to make sure that oom_score_adj is changed to pick the allocating process for oom-killing.
I will send the updated patch.
Thanks
Vaibhav Nagarnaik
| |