lkml.org 
[lkml]   [2011]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v15 10/10] usb:dummy_hcd: Force FS device connection according to module parameter
Date
> > I'm not talking about dummy_hcd. It was a general comment about the
> gadget
> > code. I can't give you an example from the top of my head...
>
> Oh. Well, if you're writing new code and you come across a place where
> an error message really is needed, you should add the error message.

Ok, I'll take that into consideration. Since I'm new here I was "afraid" to
add any changes that are not really required :)


> But if the parameters are contradictory, you don't know _how_ to fix
> it. If is_super_speed is True and is_high_speed is False, did the user
> want to add SuperSpeed support or to remove high-speed support?
>
> Besides, the best (i.e., easiest and most likely to be correct) way of
> fixing the error is for the user to issue the modprobe command again,
> with the correct parameters this time. Therefore the driver should
> fail to load, so that the modprobe can be reissued with no need to do
> rmmod first.
>

Ok, agreed. I'll update the patch.


Thanks,
Tanya Brokhman
---
Sent by an consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.






\
 
 \ /
  Last update: 2011-06-07 20:51    [W:0.063 / U:0.804 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site