Messages in this thread Patch in this message | | | Date | Tue, 7 Jun 2011 20:35:42 +0200 | From | Oleg Nesterov <> | Subject | [PATCH] do_coredump: fix the "ispipe" error check |
| |
do_coredump() assumes that if format_corename() fails it should return -ENOMEM. This is not true, for example cn_print_exe_file() can propagate the error from d_path. Even if it was true, this is too fragile. Change the code to check "ispipe < 0".
Signed-off-by: Oleg Nesterov <oleg@redhat.com> ---
fs/exec.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
--- ptrace/fs/exec.c~corename_errcode 2011-06-07 19:44:30.000000000 +0200 +++ ptrace/fs/exec.c 2011-06-07 20:20:48.000000000 +0200 @@ -2092,16 +2092,16 @@ void do_coredump(long signr, int exit_co ispipe = format_corename(&cn, signr); - if (ispipe == -ENOMEM) { - printk(KERN_WARNING "format_corename failed\n"); - printk(KERN_WARNING "Aborting core\n"); - goto fail_corename; - } - if (ispipe) { int dump_count; char **helper_argv; + if (ispipe < 0) { + printk(KERN_WARNING "format_corename failed\n"); + printk(KERN_WARNING "Aborting core\n"); + goto fail_corename; + } + if (cprm.limit == 1) { /* * Normally core limits are irrelevant to pipes, since
| |