Messages in this thread | | | Subject | Re: Seeing DMAR errors after multiple load/unload with SR-IOV | From | David Woodhouse <> | Date | Tue, 07 Jun 2011 14:46:53 +0100 |
| |
On Tue, 2011-06-07 at 06:38 -0700, Chris Wright wrote: > I think we still leak the list entry though. Bottom line is that we > need to handle hotplug ADD_DEVICE and DEL_DEVICE notifications. We > happen to pick up ADD_DEVICE by accident, but it's all pretty sloppy.
Yeah, keeping a list of possible stale 'pci_dev' pointers is stupid. We should figure out the matching DMAR unit directly from the ACPI table at ADD_DEVICE time, and store it in pdev->archdata.iommu.
I saw patches which were going in that direction...
-- dwmw2
| |