lkml.org 
[lkml]   [2011]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [tip:core/debug] debug: Make CONFIG_EXPERT select CONFIG_DEBUG_KERNEL to unhide debug options

    * Josh Triplett <josh@joshtriplett.org> wrote:

    > On Mon, Jun 06, 2011 at 11:45:04PM +0200, Frederic Weisbecker wrote:
    > > On Mon, Jun 06, 2011 at 09:39:40PM +0000, tip-bot for Josh Triplett wrote:
    > > > Commit-ID: 2458073da04571182748aa4289630dca52ba63cc
    > > > Gitweb: http://git.kernel.org/tip/2458073da04571182748aa4289630dca52ba63cc
    > > > Author: Josh Triplett <josh@joshtriplett.org>
    > > > AuthorDate: Mon, 6 Jun 2011 09:51:30 -0700
    > > > Committer: Ingo Molnar <mingo@elte.hu>
    > > > CommitDate: Mon, 6 Jun 2011 19:30:01 +0200
    > > >
    > > > debug: Make CONFIG_EXPERT select CONFIG_DEBUG_KERNEL to unhide debug options
    > > >
    > > > Several debugging options currently default to y, such as
    > > > CONFIG_DEBUG_BUGVERBOSE and CONFIG_DEBUG_RODATA.
    > > >
    > > > Embedded users might want to turn those options off to save space;
    > > > however, turning them off requires turning on CONFIG_DEBUG_KERNEL to
    > > > unhide them. Since CONFIG_DEBUG_KERNEL exists specifically to
    > > > unhide debugging options, and CONFIG_EXPERT exists specifically
    > > > to unhide options potentially needed by experts and/or embedded
    > > > users, make CONFIG_EXPERT automatically imply CONFIG_DEBUG_KERNEL.
    > > >
    > > > Change various debugging options to only reference DEBUG_KERNEL,
    > > > not EXPERT.
    > > >
    > > > Note that DEBUG_MEMORY_INIT defaulted to !EXPERT, which seemed
    > > > wrong, since EXPERT should not directly affect anything except
    > > > the availability of other options. (And EXPERT definitely
    > > > shouldn't mean "implicitly turn off default safety features".)
    > > >
    > > > Change it to default to y, which means that turning on EXPERT
    > > > does not automatically disable it, but will provide the option
    > > > to disable it.
    > > >
    > > > Signed-off-by: Josh Triplett <josh@joshtriplett.org>
    > > > Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
    > >
    > > No, Nacked actually. I'm fine with the v2 that only changed
    > > the EXPERT config to imply DEBUG_KERNEL. But all the other
    > > changes here need to be revised, as I outlined in the thread.
    >
    > Fixed in v4; please replace the patch in tip with that.

    i applied the much simpler v2 twoliner version instead.

    Thanks,

    Ingo


    \
     
     \ /
      Last update: 2011-06-07 12:21    [W:0.023 / U:2.344 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site