Messages in this thread | | | From | Grant Likely <> | Date | Mon, 6 Jun 2011 11:37:58 -0600 | Subject | Re: [PATCH] gpio: reorganize drivers |
| |
On Mon, Jun 6, 2011 at 11:33 AM, Grant Likely <grant.likely@secretlab.ca> wrote: > On Mon, Jun 6, 2011 at 11:27 AM, Roland Dreier <roland@purestorage.com> wrote: >> On Mon, Jun 6, 2011 at 12:06 AM, Grant Likely <grant.likely@secretlab.ca> wrote: >>> Sort the gpio makefile and enforce the naming convention gpio-*.c for >>> gpio drivers. >> >> OK, bikeshed colors here, but... what is the benefit of >> 'drivers/gpio/gpio-xxx.c' vs >> just 'drivers/gpio/xxx.c'? Seems like one 'gpio' should be enough for anyone... > > lsmod
Specifically, module names don't give any clues about which directory they were loaded out of, so it is useful to have the module name reflect exactly what the module is for. Second, a lot of these gpio/spi/i2c cores end up being stuffed into an integrated chipset where they all pretty much share the same name, but the drivers are for different functional blocks. ie. gpio-omap.o, spi-omap.o, i2c-omap.o
g.
-- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |