lkml.org 
[lkml]   [2011]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf: fix missing event name init for default event

* Stephane Eranian <eranian@google.com> wrote:

> @@ -87,6 +87,13 @@ int perf_evlist__add_default(struct perf_evlist *evlist)
> if (evsel == NULL)
> return -ENOMEM;
>
> + /* use strdup() because free(evsel) assumes name is allocated */
> + evsel->name = strdup("cycles");
> + if (!evsel->name) {
> + free(evsel);
> + return -ENOMEM;
> + }
> +
> perf_evlist__add(evlist, evsel);
> return 0;
> }

Hm, nice fix, but this function should really follow the standard
exception tear-down sequence pattern we use in the kernel:

if (evsel == NULL)
goto err;

...

if (!evsel->name)
goto err_free;

...

return 0;

err_free:
free(evsel);
err:
return -ENOMEM;

Thanks,

Ingo


\
 
 \ /
  Last update: 2011-06-06 19:35    [W:0.037 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site