lkml.org 
[lkml]   [2011]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH RFC] fs: introduce a default_open for simple f_op->open use
From
Date
On Thu, 2011-06-02 at 15:04 -0700, H Hartley Sweeten wrote:
> There are many f_op->open implementations that simply do:
>
> file->private_data = inode->i_private;
>
> This introduces a new global symbol, default_open, that can be
> used instead of the private implementations.
>
> This also removes a couple private implementations that share the
> same symbol name.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Alexander Viro <viro@zeniv.linux.org.uk>
> Cc: Matthew Wilcox <matthew@wil.cx>
> Cc: Artem Bityutskiy <dedekind1@gmail.com>
> Cc: David Woodhouse <dwmw2@infradead.org>
> Cc: Robert Richter <robert.richter@amd.com>
> Cc: Greg Kroah-Hartman <gregkh@suse.de>
> Cc: James Morris <jmorris@namei.org>
> Cc: Nick Piggin <npiggin@kernel.dk>
> Cc: Andi Kleen <ak@linux.intel.com>
> Cc: Dave Chinner <dchinner@redhat.com>
>
> ---
>
> If this patch looks reasonable, I have some additional patches that
> convert all other similar f_op->open implemenations to use default_open
> tree wide. The full diffstat looks like this:

Looks good to me, thanks.

--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-06-06 12:43    [W:0.031 / U:0.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site