[lkml]   [2011]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 1/2] sysdev: Do not register with sysdev when erroring on add
    On Sun, Jun 05, 2011 at 07:07:34AM -0400, Brian Gerst wrote:
    > On Tue, Feb 1, 2011 at 11:19 AM, Borislav Petkov <> wrote:
    > > From: Borislav Petkov <>
    > >
    > > When encountering an error while executing the driver's ->add method, we
    > > should cancel registration and unwind what we've regged so far. The low
    > > level ->add methods do return proper error codes but those aren't looked
    > > at in sysdev_driver_register(). Fix that by sharing the unregistering
    > > code.
    > This patch is causing boot failures on a virtual machine running
    > Fedora 15 32-bit. With this patch, the microcode driver repeatedly
    > spews:
    > microcode: CPU0: AMD CPU family 0x6 not supported
    > modprobe: FATAL: Error inserting microcode: Invalid argument.
    > until eventually causing an oops. Reverting this patch allows the
    > boot to proceed.

    Yeah, we had a similar issue with a K8 machine on Fedora:

    Another fix would be if you remove the *microcode.rules in
    /etc/udev/rules.d/ which tries to load the microcode driver
    continuously. The funny thing is, this happens only on Fedora - all the
    other distros simply get the -EINVAL from the driver failing to load
    and that's it. I guess Fedora's udev doesn't accept the error value and
    continues to try to load the module.


    Advanced Micro Devices GmbH
    Einsteinring 24, 85609 Dornach
    General Managers: Alberto Bozzo, Andrew Bowd
    Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
    Registergericht Muenchen, HRB Nr. 43632

     \ /
      Last update: 2011-06-05 14:19    [W:0.025 / U:4.216 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site