[lkml]   [2011]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    SubjectRe: [tip:sched/locking] sched: Add p->pi_lock to task_rq_lock()

    * Peter Zijlstra <> wrote:

    > On Fri, 2011-06-03 at 12:02 +0200, Arne Jansen wrote:
    > > On 03.06.2011 11:15, Peter Zijlstra wrote:
    > > > Anyway, Arne, how long did you wait before power cycling the box? The
    > > > NMI watchdog should trigger in about a minute or so if it will trigger
    > > > at all (its enabled in your config).
    > >
    > > No, it doesn't trigger,
    > Bummer.

    Is there no output even when the console is configured to do an
    earlyprintk? That will allow the NMI watchdog to punch through even a
    printk or scheduler lockup.

    Arne, you can turn this on via one of these:


    (the ',keep' portion is important to have it active even after the
    regular console has been switched on.)

    Could you also please check with the (untested) patch below applied?
    This will turn off *all* printk done by the NMI watchdog and switches
    it to do pure early_printk() - which does not use any locking so it
    should never lock up.

    [ If you keep seeing 'NMI watchdog tick' messages periodically
    occuring after the lockup then i'll send a more complete patch that
    shuts off the regular printk path and makes sure that all output is
    early_printk() based only. ]

    earlyprintk=,keep with such a patch has let me down only on the
    rarest of occasions.

    ( Arne, please also double check on a working bootup that the NMI
    watchdog is actually ticking, by checking the NMI counts in
    /proc/interrupts go up slowly but surely on all CPUs. )



    diff --git a/kernel/watchdog.c b/kernel/watchdog.c
    index 3d0c56a..7c7e33f 100644
    --- a/kernel/watchdog.c
    +++ b/kernel/watchdog.c
    @@ -234,15 +234,12 @@ static void watchdog_overflow_callback(struct perf_event *event, int nmi,
    if (__this_cpu_read(hard_watchdog_warn) == true)

    - if (hardlockup_panic)
    - panic("Watchdog detected hard LOCKUP on cpu %d", this_cpu);
    - else
    - WARN(1, "Watchdog detected hard LOCKUP on cpu %d", this_cpu);
    __this_cpu_write(hard_watchdog_warn, true);

    + early_printk("NMI watchog tick %ld\n", jiffies);
    __this_cpu_write(hard_watchdog_warn, false);

     \ /
      Last update: 2011-06-05 10:21    [W:0.023 / U:177.016 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site