lkml.org 
[lkml]   [2011]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] drivers/usb/gadget: add missing kfree calls
On Sat, 04 Jun 2011 23:35:16 +0200
"Michal Nazarewicz" <mina86@mina86.com> wrote:

> On Sat, 04 Jun 2011 21:34:54 +0200, Andre Bartke
> <andre.bartke@googlemail.com> wrote:
> > diff --git a/drivers/usb/gadget/rndis.c b/drivers/usb/gadget/rndis.c
> > @@ -700,6 +701,7 @@ static int rndis_reset_response(int configNr,
> > rndis_reset_msg_type *buf)
> > resp->AddressingReset = cpu_to_le32(1);
> > params->resp_avail(params->v);
> > + kfree(r);
> > return 0;
> > }
>
> Have you tested this? It does not look right to me.
> rndis_add_response() allocates memory and puts the request on a
> list. It is later freed in rndis_free_response().
>

Nope, the only way I can test this is a build - which it does.
You might be right though.


\
 
 \ /
  Last update: 2011-06-04 23:57    [from the cache]
©2003-2011 Jasper Spaans