[lkml]   [2011]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: module: sysfs - add 'uevent' file to allow coldplug
On Thu, Jun 23, 2011 at 13:24, Kay Sievers <> wrote:
> On Thu, Jun 23, 2011 at 02:27, Rusty Russell <> wrote:
>> On Wed, 22 Jun 2011 12:17:49 +0200, Kay Sievers <> wrote:
>>> On Wed, Jun 22, 2011 at 04:00, Rusty Russell <> wrote:
>>> > Now we've got that sorted, is there a reason why you changed all the
>>> > signatures rather than just using mod->mkobj in store_uevent()?
>>> Because we should be able to use the same 'struct module_attribute'
>>> for built-in modules and for loaded modules at the same time. The
>>> current 'struct module_attribute' has 'struct module' references, but
>>> 'struct module' will never exist for built-in modules.
>>> 'Struct module_kobject' has nice back-pointer to 'struct module', so
>>> this was the simplest to do, and looks still fine, I thought.
>> Yes, it's weird.  The only reason it currently works is because we don't
>> use the mod parameter in param_attr_show and param_attr_store; it's NULL
>> for built-in modules.
>> I'd prefer that patch first, I think: it's a sensible cleanup.
> You want the patch split up in two? You want to remove the mod
> parameter somehow?

Can we get these 20 lines of code sorted out please? :)

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2011-07-01 05:11    [from the cache]
©2003-2014 Jasper Spaans. hosted at Digital Ocean