Messages in this thread | | | From | Kay Sievers <> | Date | Fri, 1 Jul 2011 05:07:41 +0200 | Subject | Re: module: sysfs - add 'uevent' file to allow coldplug |
| |
On Thu, Jun 23, 2011 at 13:24, Kay Sievers <kay.sievers@vrfy.org> wrote: > On Thu, Jun 23, 2011 at 02:27, Rusty Russell <rusty@rustcorp.com.au> wrote: >> On Wed, 22 Jun 2011 12:17:49 +0200, Kay Sievers <kay.sievers@vrfy.org> wrote: >>> On Wed, Jun 22, 2011 at 04:00, Rusty Russell <rusty@rustcorp.com.au> wrote: > >>> > Now we've got that sorted, is there a reason why you changed all the >>> > signatures rather than just using mod->mkobj in store_uevent()? >>> >>> Because we should be able to use the same 'struct module_attribute' >>> for built-in modules and for loaded modules at the same time. The >>> current 'struct module_attribute' has 'struct module' references, but >>> 'struct module' will never exist for built-in modules. >>> >>> 'Struct module_kobject' has nice back-pointer to 'struct module', so >>> this was the simplest to do, and looks still fine, I thought. >> >> Yes, it's weird. The only reason it currently works is because we don't >> use the mod parameter in param_attr_show and param_attr_store; it's NULL >> for built-in modules. >> >> I'd prefer that patch first, I think: it's a sensible cleanup. > > You want the patch split up in two? You want to remove the mod > parameter somehow?
Can we get these 20 lines of code sorted out please? :)
Kay -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |