lkml.org 
[lkml]   [2011]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] USB: EHCI: Move sysfs related bits into ehci-sysfs.c
On Sat, Jun 25, 2011 at 08:10:52AM -0400, Alan Stern wrote:
> On Fri, 24 Jun 2011, Kirill Smelkov wrote:
>
> > The only sysfs attr implemented so far is "companion" from ehci-hub.c,
> > but in the next patch we are going to add another sysfs file, so prior
> > to that let's structure things and move already-in-there sysfs code to
> > separate file.
> >
> > Signed-off-by: Kirill Smelkov <kirr@mns.spb.ru>
> > diff --git a/drivers/usb/host/ehci-sysfs.c b/drivers/usb/host/ehci-sysfs.c
> > new file mode 100644
> > index 0000000..347c8cb
> > --- /dev/null
> > +++ b/drivers/usb/host/ehci-sysfs.c
> > @@ -0,0 +1,94 @@
> > +/*
> > + * Copyright (C) 2001-2004 by David Brownell
>
> One little note... It's understandable that you put this line here,
> but it isn't really appropriate. All the code you're moving into this
> new file was written by me.

Now I see, yes, in 57e06c11 (EHCI: force high-speed devices to run at
full speed; Jan 16 2007).

> Apart from that one issue,
>
> Acked-off-by: Alan Stern <stern@rowland.harvard.edu>

Thanks.

What should we do with this patch now? Should I put


Copyright (C) 2007 by Alan Stern

there? Or something else?

Or maybe drop that copyright notice altogether becase usually it gets
outdated very quickly, and who made what is visible through git
log/blame?


I'm ok with any case, please just tell me how to proceed.


And what about main "[PATCH v2 2/2] USB: EHCI: Allow users to override
80% max periodic bandwidth"?

Was it Acked together with this one, or not and review is pending?
Curious because I'm new here...


Thanks,
Kirill


\
 
 \ /
  Last update: 2011-06-29 11:23    [from the cache]
©2003-2011 Jasper Spaans