Messages in this thread | | | Date | Wed, 29 Jun 2011 13:10:39 -0700 | Subject | Re: [PATCH] plist: add mutex to the blessed lock type for plists | From | Dima Zavin <> |
| |
On Wed, Jun 29, 2011 at 1:01 PM, Steven Rostedt <rostedt@goodmis.org> wrote: > On Wed, 2011-06-29 at 12:33 -0700, Dima Zavin wrote: > >> +#include <linux/mutex.h> >> #include <linux/plist.h> >> #include <linux/spinlock.h> >> >> @@ -56,11 +57,14 @@ static void plist_check_list(struct list_head *top) >> >> static void plist_check_head(struct plist_head *head) >> { >> - WARN_ON(head != &test_head && !head->rawlock && !head->spinlock); >> + WARN_ON(head != &test_head && !head->rawlock && !head->spinlock && >> + !head->mutex); >> if (head->rawlock) >> WARN_ON_SMP(!raw_spin_is_locked(head->rawlock)); >> if (head->spinlock) >> WARN_ON_SMP(!spin_is_locked(head->spinlock)); >> + if (head->mutex) >> + WARN_ON_SMP(!mutex_is_locked(head->mutex)); > > Spin locks are NOPs on SMP, but mutexes are not. Are you sure you want > this as WARN_ON_SMP()?
Doh. Copy-pasty-itis.. Will switch to plain WARN_ON.
--Dima
> > -- Steve > >> if (!plist_head_empty(head)) >> plist_check_list(&plist_first(head)->prio_list); >> plist_check_list(&head->node_list); > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |