lkml.org 
[lkml]   [2011]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] plist: add mutex to the blessed lock type for plists
From
Date
On Wed, 2011-06-29 at 12:33 -0700, Dima Zavin wrote:

> +#include <linux/mutex.h>
> #include <linux/plist.h>
> #include <linux/spinlock.h>
>
> @@ -56,11 +57,14 @@ static void plist_check_list(struct list_head *top)
>
> static void plist_check_head(struct plist_head *head)
> {
> - WARN_ON(head != &test_head && !head->rawlock && !head->spinlock);
> + WARN_ON(head != &test_head && !head->rawlock && !head->spinlock &&
> + !head->mutex);
> if (head->rawlock)
> WARN_ON_SMP(!raw_spin_is_locked(head->rawlock));
> if (head->spinlock)
> WARN_ON_SMP(!spin_is_locked(head->spinlock));
> + if (head->mutex)
> + WARN_ON_SMP(!mutex_is_locked(head->mutex));

Spin locks are NOPs on SMP, but mutexes are not. Are you sure you want
this as WARN_ON_SMP()?

-- Steve

> if (!plist_head_empty(head))
> plist_check_list(&plist_first(head)->prio_list);
> plist_check_list(&head->node_list);




\
 
 \ /
  Last update: 2011-06-29 22:05    [W:0.056 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site